Skip to content

[API] Support zero_infinity in ctc_loss #75742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 36 commits into from
Oct 31, 2025
Merged

[API] Support zero_infinity in ctc_loss #75742

merged 36 commits into from
Oct 31, 2025

Conversation

@aztice
Copy link
Contributor

@aztice aztice commented Oct 11, 2025 •
edited
Loading

PR Category

User Experience

PR Types

New features

Description

为 ctc_loss 添加 zero_infinity 参数

@paddle-bot
Copy link

paddle-bot bot commented Oct 11, 2025

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Oct 11, 2025
@aztice
Copy link
Contributor Author

aztice commented Oct 11, 2025

/re-run all-failed

@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Oct 11, 2025
@luotao1 luotao1 self-assigned this Oct 11, 2025
@aztice
Copy link
Contributor Author

aztice commented Oct 11, 2025

/re-run all-failed

@aztice
Copy link
Contributor Author

aztice commented Oct 11, 2025 •
edited
Loading 

Assert Diff Coverage
no data found
Assert Python Diff Coverage
expected >= 90.0 %, actual 50.0 %, failed
The title does not start with cinn or typing or codestyle or fluid_ops or 3.13
9
Coverage check failed, unit tests have all passed, please do not rerun, check whether the newly added code lines are fully covered by unit tests. If you have any questions, please contact XieYunshen.

看起来 CI 似乎是可以忽略的

@aztice
Copy link
Contributor Author

aztice commented Oct 11, 2025

/re-run all-failed

@aztice aztice changed the title feat: ctc_loss.zero_infinity fluid_ops/feat: support zero_infinity in ctc_loss Oct 13, 2025
@aztice
Copy link
Contributor Author

aztice commented Oct 13, 2025

/re-run all-failed

@aztice
Copy link
Contributor Author

aztice commented Oct 13, 2025

@XiaoguangHu01
@SigureMo
两位Reviewer可以帮我review下吗，CI需要

@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (develop@f556d04). Learn more about missing BASE report.

Additional details and impacted files 
@@             Coverage Diff             @@
##             develop    #75742   +/-   ##
===========================================
  Coverage           ?   100.00%           
===========================================
  Files              ?         1           
  Lines              ?         4           
  Branches           ?         0           
===========================================
  Hits               ?         4           
  Misses             ?         0           
  Partials           ?         0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

zxcd
zxcd reviewed Oct 14, 2025
View reviewed changes
@zxcd
Copy link
Contributor

zxcd commented Oct 14, 2025 •
edited
Loading

add new parameter also need to add it to test to pass Coverage CI.

@aztice
Copy link
Contributor Author

aztice commented Oct 15, 2025

/re-run all-failed

@aztice aztice requested a review from zxcd October 15, 2025 08:59
zxcd
zxcd approved these changes Oct 17, 2025
View reviewed changes
Copy link
Contributor

@zxcd zxcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aztice aztice requested review from SigureMo and jeff41404 October 30, 2025 12:49
aztice added 5 commits October 30, 2025 20:51
@aztice
Format labels_np initialization for readability
2f0af5a
@aztice
Refactor string literals and improve formatting
3f132ca
@aztice
Improve code formatting in test_warpctc_op.py
6e0cc73 
Refactor code for better readability by adjusting line breaks and formatting in test_warpctc_op.py.
@aztice
Refactor static_graph context manager usage
6c7c51a
@aztice
Use fixed seed value in static_graph context manager
fe2834a 
Replaced the use of self.seed with a fixed seed value for consistency in tests.
SigureMo
SigureMo reviewed Oct 30, 2025
View reviewed changes
@aztice
Refactor static graph usage in CTC loss test
0ca8eb1 
Refactored test to use paddle.enable_static() and removed context manager for static graph.
SigureMo
SigureMo requested changes Oct 30, 2025
View reviewed changes
@aztice
Copy link
Contributor Author

aztice commented Oct 30, 2025

/re-run all-failed

SigureMo
SigureMo requested changes Oct 31, 2025
View reviewed changes
SigureMo
SigureMo reviewed Oct 31, 2025
View reviewed changes
@aztice
Copy link
Contributor Author

aztice commented Oct 31, 2025

/re-run all-failed

@aztice aztice requested a review from SigureMo October 31, 2025 03:42
SigureMo
SigureMo reviewed Oct 31, 2025
View reviewed changes
@SigureMo SigureMo merged commit 8036231 into PaddlePaddle:develop Oct 31, 2025
102 of 106 checks passed
@aztice aztice deleted the 1e30 branch October 31, 2025 09:24
@SigureMo
Copy link
Member

SigureMo commented Oct 31, 2025

我刚刚没注意，CTCLoss 的实现有问题吧？为什么新增参数 zero_infinity 是作为 forward 输入？torch 是 __init__ 的输入吧？？？

@aztice
Copy link
Contributor Author

aztice commented Oct 31, 2025

我刚刚没注意，CTCLoss 的实现有问题吧？为什么新增参数 zero_infinity 是作为 forward 输入？torch 是 __init__ 的输入吧？？？

稍等我看看

@aztice
Copy link
Contributor Author

aztice commented Oct 31, 2025

我刚刚没注意，CTCLoss 的实现有问题吧？为什么新增参数 zero_infinity 是作为 forward 输入？torch 是 __init__ 的输入吧？？？

确认了下，稍等我开个新PR改下，forward 以及 __init__ 均支持输入。

@aztice
Copy link
Contributor Author

aztice commented Oct 31, 2025

@SigureMo #76156
转这里

@SigureMo SigureMo mentioned this pull request Oct 31, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SigureMo SigureMo SigureMo approved these changes

@luotao1 luotao1 Awaiting requested review from luotao1

@jeff41404 jeff41404 Awaiting requested review from jeff41404

+1 more reviewer

@zxcd zxcd zxcd approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@luotao1 luotao1

@jeff41404 jeff41404

@zxcd zxcd

Labels

contributor External developers HappyOpenSource 快乐开源活动issue与PR skip-ci: Doc-Preview skip-ci: static-check

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@aztice @codecov-commenter @zxcd @jeff41404 @SigureMo @luotao1